Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctor: add check/fix for bogus Action rows #19656

Merged
merged 8 commits into from
May 10, 2022

Conversation

singuliere
Copy link
Contributor

@singuliere singuliere commented May 8, 2022

Signed-off-by: Loïc Dachary <loic@dachary.org>
@singuliere singuliere added type/enhancement An improvement of existing functionality backport/v1.16 labels May 8, 2022
@singuliere singuliere added this to the 1.17.0 milestone May 8, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 8, 2022
@singuliere singuliere changed the title doctor: add check/fix for orphaned Action rows doctor: add check/fix for bugous Action rows May 8, 2022
Signed-off-by: Loïc Dachary <loic@dachary.org>
models/consistency.go Show resolved Hide resolved
models/consistency_test.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 8, 2022
@zeripath zeripath changed the title doctor: add check/fix for bugous Action rows doctor: add check/fix for orphaned Action rows May 8, 2022
@zeripath zeripath changed the title doctor: add check/fix for orphaned Action rows doctor: add check/fix for bogus Action rows May 8, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2022
@lunny
Copy link
Member

lunny commented May 9, 2022

Please update the branch

models/consistency.go Outdated Show resolved Hide resolved
@6543
Copy link
Member

6543 commented May 9, 2022

@singuliere can you "update branch" again :)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@7e19200). Click here to learn what that means.
The diff coverage is 36.36%.

@@           Coverage Diff           @@
##             main   #19656   +/-   ##
=======================================
  Coverage        ?   47.34%           
=======================================
  Files           ?      957           
  Lines           ?   133583           
  Branches        ?        0           
=======================================
  Hits            ?    63244           
  Misses          ?    62689           
  Partials        ?     7650           
Impacted Files Coverage Δ
modules/doctor/dbconsistency.go 4.79% <0.00%> (ø)
models/consistency.go 11.66% <61.53%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e19200...3f8be07. Read the comment docs.

@6543
Copy link
Member

6543 commented May 10, 2022

🚀

@6543 6543 merged commit 443675d into go-gitea:main May 10, 2022
singuliere added a commit to singuliere/gitea that referenced this pull request May 10, 2022
Co-authored-by: Loïc Dachary <loic@dachary.org>

Conflicts:
	models/consistency_test.go
	 trivial context conflict.
lafriks pushed a commit that referenced this pull request May 10, 2022
Co-authored-by: Loïc Dachary <loic@dachary.org>

Conflicts:
	models/consistency_test.go
	 trivial context conflict.
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 10, 2022
* giteaofficial/main:
  Use better message for consistency check (go-gitea#19672)
  Fix new release from tags list UI (go-gitea#19670)
  Update go deps (go-gitea#19665)
  [doctor] Add check/fix for bogus action rows (go-gitea#19656)
  [skip ci] Updated translations via Crowdin
  Add tooltip to pending PR comments (go-gitea#19662)
  Add Webfinger endpoint (go-gitea#19462)
  Update documentation to disable duration settings with -1 instead of 0 (go-gitea#19647)
  Set the LastModified header for raw files (go-gitea#18356)
  Don't select join table's columns (go-gitea#19660)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
Signed-off-by: Loïc Dachary <loic@dachary.org>
Co-authored-by: Loïc Dachary <loic@dachary.org>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 error accessing dashboard after upgrade to 1.16.1 from 1.15.10, caused by mismatched SQLite colmun type
8 participants