Prevent NPE when checking repo units if the user is nil #19625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheckRepoUnitUser should tolerate nil users. Fix go-gitea#19613 Signed-off-by: Andrew Thornton <art27@cantab.net>
Gusted
approved these changes
May 5, 2022
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
May 6, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #19625 +/- ##
=======================================
Coverage ? 47.39%
=======================================
Files ? 954
Lines ? 132760
Branches ? 0
=======================================
Hits ? 62916
Misses ? 62266
Partials ? 7578
Continue to review full report at Codecov.
|
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 6, 2022
Backport go-gitea#19625 CheckRepoUnitUser should tolerate nil users. Fix go-gitea#19613 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
added a commit
that referenced
this pull request
May 6, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 6, 2022
* giteaofficial/main: Simplify `IsVendor` (go-gitea#19626) Prevent NPE when checking repo units if the user is nil (go-gitea#19625) Skip duplicated layers. (go-gitea#19624) Add "Reference" section to Issue view sidebar (go-gitea#19609) GetFeeds must always discard actions with dangling repo_id (go-gitea#19598)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
CheckRepoUnitUser should tolerate nil users. Fix go-gitea#19613 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckRepoUnitUser should tolerate nil users.
Fix #19613
Signed-off-by: Andrew Thornton art27@cantab.net