Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont overwrite err with nil (part #19572) #19574

Merged
merged 2 commits into from
May 1, 2022
Merged

Dont overwrite err with nil (part #19572) #19574

merged 2 commits into from
May 1, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented May 1, 2022

Partial Backport #19572

@6543 6543 added the type/bug label May 1, 2022
@6543 6543 added this to the 1.16.7 milestone May 1, 2022
@6543 6543 requested a review from Gusted May 1, 2022 23:01
@6543 6543 mentioned this pull request May 1, 2022
Merged
Gusted
Gusted reviewed May 1, 2022
View reviewed changes
services/pull/check.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2022
@6543
Update services/pull/check.go
8a84ba8 
Co-authored-by: Gusted <williamzijl7@hotmail.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 1, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2022
@6543 6543 merged commit f7330fd into go-gitea:release/v1.16 May 1, 2022
@6543 6543 deleted the backport-fix-of-19572 branch May 1, 2022 23:54
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.16.7
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @Gusted @delvh @GiteaBot