Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github style following followers #19482

Merged
merged 5 commits into from
May 25, 2022
Merged

Github style following followers #19482

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79cb2b6
Github style following followers
istiak101 Apr 25, 2022
dddec64
remove trailing whitespace
istiak101 Apr 25, 2022
4a384ef
muted class for links
istiak101 May 21, 2022
eaf659d
Merge branch 'main' into patch-1
lunny May 21, 2022
ec12fc1
Merge branch 'main' into patch-1
wxiaoguang May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions templates/user/profile.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
{{if .Owner.FullName}}<span class="header text center">{{.Owner.FullName}}</span>{{end}}
<span class="username text center">{{.Owner.Name}}</span>
<a href="{{.Owner.HomeLink}}.rss"><i class="ui grey icon tooltip ml-3" data-content="{{.i18n.Tr "rss_feed"}}" data-position="bottom center">{{svg "octicon-rss" 18}}</i></a>
<i class="ui grey icon tooltip ml-3">{{svg "octicon-person" 18}}</i>
<a href="{{.Owner.HomeLink}}?tab=followers">{{.Owner.NumFollowers}} {{.i18n.Tr "user.followers"}}</a> .
<a href="{{.Owner.HomeLink}}?tab=following">{{.Owner.NumFollowing}} {{.i18n.Tr "user.following"}}</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<i class="ui grey icon tooltip ml-3">{{svg "octicon-person" 18}}</i>
<a href="{{.Owner.HomeLink}}?tab=followers">{{.Owner.NumFollowers}} {{.i18n.Tr "user.followers"}}</a> .
<a href="{{.Owner.HomeLink}}?tab=following">{{.Owner.NumFollowing}} {{.i18n.Tr "user.following"}}</a>
<a class="muted" href="{{.Owner.HomeLink}}?tab=followers">{{svg "octicon-person" 18 "mr-2"}}{{.Owner.NumFollowers}} {{.i18n.Tr "user.followers"}}</a> · <a class="muted" href="{{.Owner.HomeLink}}?tab=following">{{.Owner.NumFollowing}} {{.i18n.Tr "user.following"}}</a>

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. I really needed the "muted" class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything missing? The UI on try.gitea.io is not the same as the screenshot.

</div>
<div class="extra content word-break">
<ul>
Expand Down Expand Up @@ -108,18 +111,6 @@
{{svg "octicon-eye"}} {{.i18n.Tr "user.watched"}}
</a>
{{end}}
<a class='{{if eq .TabName "following"}}active{{end}} item' href="{{.Owner.HomeLink}}?tab=following">
{{svg "octicon-person"}} {{.i18n.Tr "user.following"}}
{{if .Owner.NumFollowing}}
<div class="ui primary label">{{.Owner.NumFollowing}}</div>
{{end}}
</a>
<a class='{{if eq .TabName "followers"}}active{{end}} item' href="{{.Owner.HomeLink}}?tab=followers">
{{svg "octicon-person"}} {{.i18n.Tr "user.followers"}}
{{if .Owner.NumFollowers}}
<div class="ui primary label">{{.Owner.NumFollowers}}</div>
{{end}}
</a>
</div>

{{if eq .TabName "activity"}}
Expand Down