Prevent dangling cat-file calls (goroutine alternative) (#19454) #19466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an `os/exec.Command` is passed non `*os.File` as an input/output, go will create `os.Pipe`s and wait for their closure in `cmd.Wait()`. If the code following this is responsible for closing `io.Pipe`s or other handlers then on process death from context cancellation the `Wait` can hang. There are two possible solutions: 1. use `os.Pipe` as the input/output as `cmd.Wait` does not wait for these. 2. create a goroutine waiting on the context cancellation that will close the inputs. This PR provides the second option - which is a simpler change that can be more easily backported. Closes go-gitea#19448 Signed-off-by: Andrew Thornton <art27@cantab.net>
jolheiser
approved these changes
Apr 22, 2022
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Apr 22, 2022
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #19454
If an
os/exec.Commandis passed non*os.Fileas an input/output, gowill create
os.Pipes and wait for their closure incmd.Wait(). Ifthe code following this is responsible for closing
io.Pipes or otherhandlers then on process death from context cancellation the
Waitcanhang.
There are two possible solutions:
os.Pipeas the input/output ascmd.Waitdoes not wait for these.This PR provides the second option - which is a simpler change that can
be more easily backported.
Signed-off-by: Andrew Thornton art27@cantab.net