Skip to content

Mark TemplateLoading error as "UnprocessableEntity" (#19445) #19446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 22, 2022
Merged

Mark TemplateLoading error as "UnprocessableEntity" (#19445) #19446

merged 6 commits into from
Apr 22, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Apr 20, 2022

Mark TemplateLoading error as "UnprocessableEntity" (go-gitea#19445)
95f8671 
- Backport go-gitea#19445
  - Don't return Internal Server error if the user provide incorrect label template, instead return UnprocessableEntity.
  - Resolves go-gitea#19399
@Gusted Gusted added this to the 1.16.6 milestone Apr 20, 2022
@Gusted Gusted added type/bug modifies/api This PR adds API routes or modifies them labels Apr 20, 2022
@6543 6543 modified the milestones: 1.16.6, 1.16.7 Apr 20, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 21, 2022
@delvh delvh self-requested a review April 21, 2022 00:16
delvh
delvh reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it would work, which it currently doesn't, see CI.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2022
@Gusted
Copy link
Contributor Author

Gusted commented Apr 21, 2022

Fixed CI error

@lunny
Copy link
Member

lunny commented Apr 22, 2022

CI failure is related.

@Gusted
Copy link
Contributor Author

Gusted commented Apr 22, 2022

CI failure is related.

Ehm which CI failure?

@6543
Copy link
Member

6543 commented Apr 22, 2022

☝️ docker failed because of this outdated dependency ?!? ... upgraded

@6543 6543 merged commit 1f0dca4 into go-gitea:release/v1.16 Apr 22, 2022
@Gusted Gusted deleted the backport-19445 branch April 22, 2022 19:19
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug

Projects

None yet

Milestone

1.16.7

Development

Successfully merging this pull request may close these issues.

7 participants

@Gusted @lunny @6543 @wxiaoguang @delvh @GiteaBot @zeripath