Hide sensitive content on admin panel progress monitor (#19218 & #19226) #19231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanitize urls within git process descriptions. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Andrew Thornton <art27@cantab.net>
lunny
added
the
topic/security
zeripath
approved these changes
Mar 27, 2022
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Mar 27, 2022
GiteaBot
added
lgtm/done
zeripath
suggested changes
Mar 27, 2022
Contributor
zeripath
left a comment
zeripath
left a comment
There was a problem hiding this comment.
This isn't the complete backport - I'll merge the changes back in
Backport go-gitea#19226 The git command by default adds a number of global arguments. These are not helpful to be displayed in the process manager and so should be skipped for default process descriptions. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
changed the title
zeripath
approved these changes
Mar 27, 2022
zeripath
reviewed
Mar 27, 2022
Contributor
|
make lgtm work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #19218
Backport #19226
Sanitize urls within git process descriptions & skip global arguments.
Co-authored-by: wxiaoguang wxiaoguang@gmail.com
Co-authored-by: Andrew Thornton art27@cantab.net