Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom favicon when viewing static files if it exists (#19130) #19152

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Use custom favicon when viewing static files if it exists (#19130) #19152

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aae7eab
Use custom favicon when viewing static files if it exists (#19130)
abheekda1 Mar 19, 2022
c7c450c
Merge branch 'release/v1.16' into backport-19130-v1.16
zeripath Mar 20, 2022
2ba9d8a
Merge branch 'release/v1.16' into backport-19130-v1.16
zeripath Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use custom favicon when viewing static files if it exists (#19130) 
Redirect `/favicon.ico` to `/assets/img/favicon.png`.

Fix #19109
  • Loading branch information
@abheekda1
abheekda1 committed Mar 20, 2022
commit aae7eab1fa5ede3626c2f6a156f03a09f95dee66
5 changes: 5 additions & 0 deletions routers/web/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ func Routes(sessioner func(http.Handler) http.Handler) *web.Route {
http.Redirect(w, req, path.Join(setting.StaticURLPrefix, "/assets/img/apple-touch-icon.png"), 301)
})

// redirect default favicon to the path of the custom favicon with a default as a fallback
routes.Get("/favicon.ico", func(w http.ResponseWriter, req *http.Request) {
http.Redirect(w, req, path.Join(setting.StaticURLPrefix, "/assets/img/favicon.png"), 301)
})

common := []interface{}{}

if setting.EnableGzip {
Expand Down