Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for get user by email #18833

Merged
merged 6 commits into from
Feb 21, 2022
Merged

Fix bug for get user by email #18833

merged 6 commits into from
Feb 21, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 20, 2022

Fix #18830

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.16 labels Feb 20, 2022
@lunny lunny added this to the 1.17.0 milestone Feb 20, 2022
@lunny lunny mentioned this pull request Feb 20, 2022
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 20, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 20, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@e039b76). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18833   +/-   ##
=======================================
  Coverage        ?   46.61%           
=======================================
  Files           ?      853           
  Lines           ?   122470           
  Branches        ?        0           
=======================================
  Hits            ?    57088           
  Misses          ?    58502           
  Partials        ?     6880
Impacted Files Coverage Δ
models/user/user.go 59.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e039b76...15c47b5. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 21, 2022
@lunny lunny merged commit dc988ea into go-gitea:main Feb 21, 2022
@lunny lunny deleted the lunny/fix_get_user branch February 21, 2022 14:20
zeripath pushed a commit that referenced this pull request Feb 21, 2022
@lunny
Fix bug for get user by email (#18834)
86c3481 
Backport #18833

Fix #18830
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 22, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a5156b2 
* giteaofficial/main:
  Fix bug for get user by email (go-gitea#18833)
  migrations: remove dead code in gitea uploader (go-gitea#18725)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny @zeripath
Fix bug for get user by email (go-gitea#18833)
d2148a1 
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

GetUserByEmailContext erroneous handling of email case
5 participants
@lunny @codecov-commenter @zeripath @a1012112796 @GiteaBot