Commits on Feb 14, 2022

1. Send mail to issue/pr assignee/reviewer also when OnMention is set (g… …

   …o-gitea#18707)
   
   Backport go-gitea#18707
   
   Addresses go-gitea#17892, where emails notifications are not sent to assignees (issue and PR) and reviewers (PR) when they have the email setting Only email on mention enabled.
   
   From the user experience perspective, when a user gets a issue/PR assigned or a PR review request, he/she would expect to be implicitly mentioned since the assignment or request is personal and targeting a single person only. Thus I see go-gitea#17892 as a bug. Could we therefore mark this ticket as such?
   
   The changed code just explicitly checks for the EmailNotificationsOnMention setting beside the existing EmailNotificationsEnabled check. Too rude?
   
   @lunny mentioned a mock mail server for tests, is there something ready. How could I make use of it?
   
   See go-gitea#12774 (comment)
   
   Fix go-gitea#17892

   

   flozzone authored and zeripath committed Feb 14, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for e199b64
   • Browse repository at this point

   Copy the full SHA

   e199b64 View commit details

   Browse the repository at this point in the history