Fix PR template error #1834
Merged
Fix PR template error #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
PR lit page integration tests is really needed. |
tboerger
added
the
lgtm/need 2
Member
|
LGTM |
tboerger
added
lgtm/need 1
sapk
approved these changes
May 30, 2017
appleboy
approved these changes
May 30, 2017
Member
|
LGTM |
tboerger
added
lgtm/done
Member
|
Since this breaks things, should we not backport this? @go-gitea/owners @go-gitea/advisors |
Member
Author
|
@bkcsoft What does this break? |
Member
|
@ethantkoenig sorry, it fixes a vital bug is what I meant 😉 |
Contributor
|
Hi, Would it be possible to have this one on a (possible?) upcoming 1.1.3 tag? Thanks, |
Member
|
@ethantkoenig maybe send a backport PR is good. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1542. Ensures that
PullRequestCtx.BaseRepois populated when a fork's parent does not accept pull requests (since the fork should support intra-repo pull requests).To reproduce the bug that this fixes, do the following:
repo1)repo1(call itrepo2)repo2(call itrepo3)/:username/repo2/pulls, and you should get the error described in Template error listing pull requests #1542.If you follow the above steps with my changes, you should get no such error.