Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit max-height of CodeMirror editors for issue comment and wiki #18271

Merged
merged 22 commits into from
Jun 5, 2022
Merged

Limit max-height of CodeMirror editors for issue comment and wiki #18271

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d7ca6ca
Make the wiki editor bar sticky for longer wiki edits
martijndeb Jan 14, 2022
cd15a24
Make the issue bar in the issue view sticky for issue #10675
martijndeb Jan 14, 2022
7a4079f
Make linter happy on _repository.less
martijndeb Jan 14, 2022
52c9f65
Make linter happy on _editor.less
martijndeb Jan 14, 2022
01a1dd4
Change z-index to the lowest boundary of 1
martijndeb Jan 15, 2022
4c949f9
Change z-index to the lowest boundary of 1
martijndeb Jan 15, 2022
59019e4
Merge branch 'main' into sticky_fixes
6543 Jan 17, 2022
750c20e
Merge branch 'main' into sticky_fixes
martijndeb Feb 4, 2022
52632d9
Revert changes made to wiki editor (unsticky) and add max-height
martijndeb Feb 4, 2022
fd31c52
Revert changes for the sticky title editor
martijndeb Feb 4, 2022
285efe8
Merge branch 'main' into sticky_fixes
martijndeb Feb 14, 2022
3e16879
Add max-height definition to CodeMirror-scroll
martijndeb Feb 14, 2022
9246d84
Remove CodeMirror-scroll definition
martijndeb Feb 14, 2022
c0452f9
Merge branch 'main' into sticky_fixes
wxiaoguang May 24, 2022
0fb6b70
fine tune CodeMirror min-height/max-height
wxiaoguang May 24, 2022
3379059
Merge branch 'main' into sticky_fixes
wxiaoguang May 25, 2022
9f484fb
Merge branch 'main' into sticky_fixes
wxiaoguang May 25, 2022
7030789
Merge branch 'main' into sticky_fixes
lunny Jun 4, 2022
74dee17
Merge branch 'main' into sticky_fixes
lunny Jun 4, 2022
c913515
Merge branch 'main' into sticky_fixes
lunny Jun 4, 2022
893561b
Merge branch 'main' into sticky_fixes
lunny Jun 5, 2022
ea2048d
Merge branch 'main' into sticky_fixes
lunny Jun 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions web_src/less/_editor.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,18 @@
border-bottom: 0;
}

.repository.wiki .tab[data-tab="write"] .CodeMirror {
border-top: 0;
}

.editor-toolbar {
opacity: 1 !important;
border-color: var(--color-secondary);
position: sticky;
top: 0;
z-index: 10;
martijndeb marked this conversation as resolved.
Show resolved Hide resolved
background: var(--color-body);
border-bottom: 1px solid var(--color-secondary);
}

.editor-toolbar.fullscreen {
Expand Down
4 changes: 4 additions & 0 deletions web_src/less/_repository.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,10 @@

.title {
padding-bottom: 0 !important;
position: sticky;
top: 0;
background-color: var(--color-body);
z-index: 10;

.issue-title {
margin-bottom: .5rem;
Expand Down