Skip to content

When the git repository on storage is changed, the repository modal should also be updated #18088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 24, 2021
Merged

When the git repository on storage is changed, the repository modal should also be updated #18088

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3888f8
When the git repository on storage is changed, the repository modal s…
wxiaoguang Dec 24, 2021
924ccce
Merge branch 'main' into fix-repo-empty
lunny Dec 24, 2021
4624ce3
Merge branch 'main' into fix-repo-empty
wxiaoguang Dec 24, 2021
f6ebf80
Add more comments
wxiaoguang Dec 24, 2021
3c65fe9
Merge branch 'main' into fix-repo-empty
wxiaoguang Dec 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions routers/web/repo/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,8 +840,30 @@ func renderCode(ctx *context.Context) {
ctx.Data["PageIsViewCode"] = true

if ctx.Repo.Repository.IsEmpty {
ctx.HTML(http.StatusOK, tplRepoEMPTY)
return
reallyEmpty, err := ctx.Repo.GitRepo.IsEmpty()
if err != nil {
ctx.ServerError("GitRepo.IsEmpty", err)
return
}
if reallyEmpty {
ctx.HTML(http.StatusOK, tplRepoEMPTY)
return
}
// the repo is not really empty, so we should update the modal in database
// such problem may be caused by:
// 1) an error occurs during pushing/receiving. 2) the user replaces an empty git repo manually
// and even more: the IsEmpty flag is deeply broken and should be removed with the UI changed to manage to cope with empty repos.
// it's possible for a repository to be non-empty by that flag but still 500
// because there are no branches - only tags -or the default branch is non-extant as it has been 0-pushed.
ctx.Repo.Repository.IsEmpty = false
if err = repo_model.UpdateRepositoryCols(ctx.Repo.Repository, "is_empty"); err != nil {
ctx.ServerError("UpdateRepositoryCols", err)
return
}
if err = models.UpdateRepoSize(db.DefaultContext, ctx.Repo.Repository); err != nil {
ctx.ServerError("UpdateRepoSize", err)
return
}
}

title := ctx.Repo.Repository.Owner.Name + "/" + ctx.Repo.Repository.Name
Expand Down