Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct user on releases (#17806) #17818

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Use correct user on releases (#17806) #17818

merged 2 commits into from
Nov 26, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 25, 2021 •
edited
Loading

@Gusted Gusted changed the base branch from main to release/v1.15 November 25, 2021 21:55
@Gusted
Copy link
Contributor Author

Gusted commented Nov 25, 2021

Ah nice, bots won't update if I just change the base branch.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2021
backport: Use correct user on releases
4960549 
- Backport of go-gitea#17806
- Very nice comment so that the bots will be nice to me.
@6543 6543 added this to the 1.15.7 milestone Nov 25, 2021
@6543 6543 added the type/bug label Nov 25, 2021
@6543
Copy link
Member

6543 commented Nov 26, 2021

@Gusted sorry ...

#17820 (comment)

TLD: my nil should only be used if doer is not known - for rest API

but this is for webhooks 😓

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2021
@6543 6543 requested a review from lunny November 26, 2021 03:20
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2021
@zeripath zeripath merged commit 04517e1 into go-gitea:release/v1.15 Nov 26, 2021
@zeripath zeripath changed the title Backport webhook doer Use correct user on releases (#17806) Nov 26, 2021
@Gusted Gusted deleted the backport-webhook-doer branch January 2, 2022 22:47
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.7
Development

Successfully merging this pull request may close these issues.
5 participants
@Gusted @6543 @wxiaoguang @zeripath @GiteaBot