-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve color when inverting emojis #17797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic!
Hmm Github somehow approved this while my browser crashes - Anyhow, I wanted to add a comment to my approval "We should lookout for using invert+hue-rotate as they can create weird sub-pixel artifacts, but that's another issue for another day." |
I never noticed anything like that on Mac or Windows at least. Maybe it's a Linux-only issue. |
I've seen it happening on Windows as well - it's more how browsers are rendering certain things. It's most noticeable on text-like elements which get inverted. It shouldn't be a big problem in this case, but it's not something that should be used everywhere. |
Yeah I recall there having such issues with |
Fixes: #17795
Windows:
Mac: