Fix Migrate Description (#17692) #17727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gusted
approved these changes
Nov 19, 2021
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Nov 19, 2021
GiteaBot
added
lgtm/done
techknowlogick
approved these changes
Nov 19, 2021
zeripath
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport into v.1.15 of the PR #17692
This PR sets the parameter for migrating the description of a repository : solves #17626
Actual behavior is opts.Description is only taken in account
I had to modify services/migrations/gitea_uploader.go as the parameter wasn't modified if not a set one.
Merged already on main branch
Thanks :)