Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move attachment into models/repo/ #17650

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Move attachment into models/repo/ #17650

merged 3 commits into from
Nov 19, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 15, 2021

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 15, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 16, 2021
@lunny lunny force-pushed the lunny/model_repo_part1 branch 4 times, most recently from 17fb947 to b61a084 Compare November 17, 2021 16:04
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 18, 2021
@wxiaoguang
Copy link
Contributor

Code doesn't compile (due to merged refactoring code)

@lunny
Copy link
Member Author

lunny commented Nov 19, 2021

Code doesn't compile (due to merged refactoring code)

I think it's a CI problem.

@lunny lunny merged commit fc3d082 into go-gitea:main Nov 19, 2021
@lunny lunny deleted the lunny/model_repo_part1 branch November 19, 2021 13:40
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Move attachment into models/repo/ (go-gitea#17650)
fe25203 
* Move attachment into models/repo/

* Fix test

* Fix bug
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gusted Gusted Gusted approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wxiaoguang @Gusted @GiteaBot