Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix offBy1 errors #17606

Merged
merged 12 commits into from
Nov 14, 2021
Merged

Fix offBy1 errors #17606

merged 12 commits into from
Nov 14, 2021

Commits on Nov 10, 2021

  1. Fix offBy1 errors 

    - Partially resolves go-gitea#17596
- Resolve errors from go-critic `offBy1: Index() can return -1; maybe
you wanted to do Index()+1`.
    Gusted committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    5b63a44 View commit details
    Browse the repository at this point in the history

  2. Match golang spec

    Gusted committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    9b8c07d View commit details
    Browse the repository at this point in the history

  3. Remove comments

    Gusted committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    1a525b1 View commit details
    Browse the repository at this point in the history

  4. Update migrations.go

    @wxiaoguang
    wxiaoguang authored Nov 10, 2021
    Configuration menu
    Copy the full SHA
    e0ab552 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix-offBy1

    @wxiaoguang
    wxiaoguang authored Nov 10, 2021
    Configuration menu
    Copy the full SHA
    470439c View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: delvh <dev.lh@web.de>
    @delvh
    Gusted and delvh authored Nov 10, 2021
    Configuration menu
    Copy the full SHA
    741bb6f View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Merge branch 'main' into fix-offBy1

    @wxiaoguang
    wxiaoguang authored Nov 11, 2021
    Configuration menu
    Copy the full SHA
    aa1c049 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-offBy1

    @lunny
    lunny authored Nov 11, 2021
    Configuration menu
    Copy the full SHA
    ec1d766 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-offBy1

    @wxiaoguang
    wxiaoguang authored Nov 11, 2021
    Configuration menu
    Copy the full SHA
    eab7efa View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2021

  1. Merge branch 'main' into fix-offBy1

    @wxiaoguang
    wxiaoguang authored Nov 13, 2021
    Configuration menu
    Copy the full SHA
    7a1e21e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-offBy1

    @wxiaoguang
    wxiaoguang authored Nov 13, 2021
    Configuration menu
    Copy the full SHA
    e2f9f09 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2021

  1. Merge branch 'main' into fix-offBy1

    @wxiaoguang
    wxiaoguang authored Nov 14, 2021
    Configuration menu
    Copy the full SHA
    c7f8424 View commit details
    Browse the repository at this point in the history