Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add smtp password to install page #17564

Merged
merged 6 commits into from
May 2, 2022
Merged

add smtp password to install page #17564

merged 6 commits into from
May 2, 2022

Conversation

21h
Copy link
Contributor

@21h 21h commented Nov 5, 2021

get smtp password from GITEA__mailer__PASSWD

zeripath
zeripath reviewed Nov 5, 2021
View reviewed changes
routers/install/install.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 5, 2021
@codecov-commenter

This comment was marked as outdated.

Sign in to view
@zeripath
Copy link
Contributor

zeripath commented Nov 6, 2021

hmm...

three thoughts:

  1. Given we're blandly showing the DBPasswd above I think the sec concerns about showing the SMTPPasswd on the install page can be ignored in this PR - but if you have any thoughts about handling that concern that would be useful.
  2. We're getting a lot of PRs like this - Are there other settings that would be useful? If you think there's another one you might want can we just set that now.
  3. We need to refactor our config to just make this a lot more automatic...

zeripath
zeripath reviewed Nov 6, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

@21h
Copy link
Contributor Author

21h commented Nov 7, 2021 •
edited
Loading

security on install page?)
to be more automatic:

  • create admin user with creds from ENVs
  • automatic installation without asking to press install button
  • completely turn off ssh access at installation
  • set gitea url fron ENVs, at this moment it generated from hostname and port

@stale
Copy link

stale bot commented Apr 28, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 28, 2022
@wxiaoguang
Copy link
Contributor

@zeripath Continue to merge, or close?

@stale stale bot removed the issue/stale label May 2, 2022
wxiaoguang
wxiaoguang approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is already an password input on the installation page, and no security problem, so no problem at the moment.

If this shouldn't be merged, then it could be closed with reasons.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 2, 2022
@lunny lunny added this to the 1.17.0 milestone May 2, 2022
@lunny lunny added the type/enhancement An improvement of existing functionality label May 2, 2022
@lunny
Copy link
Member

lunny commented May 2, 2022

make L-G-T-M work

@lunny lunny merged commit 0ba3ada into go-gitea:main May 2, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 3, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
94f1981 
* giteaofficial/main:
  Fix some slice problems (incorrect slice length) (go-gitea#19592)
  Fix sending empty notifications (go-gitea#19589)
  Handle the error of a missing blob object fix go-gitea#19530 (go-gitea#19552)
  Remove legacy `+build:` constraint (go-gitea#19582)
  Federation: return useful statistic information for nodeinfo (go-gitea#19561)
  Upgrade required git version to 2.0 (go-gitea#19577)
  add smtp password to install page (go-gitea#17564)
  ignore DNS error when doing migration allow/block check (go-gitea#19566)
  [skip ci] Updated translations via Crowdin
  Dont overwrite err with nil & rename PullCheckingFuncs to reflect there usage (go-gitea#19572)
  Improve UI on mobile (go-gitea#19546)
  Add API to check if team has repo access (go-gitea#19540)
@21h
Copy link
Contributor Author

21h commented May 5, 2022

наконец-то мой коммит приняли

AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@21h @zeripath
@wxiaoguang @AbdulrhmnGhanem
add smtp password to install page (go-gitea#17564)
0cc4d3a 
* add smtp password to install page

* Update routers/install/install.go

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@21h @codecov-commenter @zeripath @wxiaoguang @lunny @GiteaBot