Add integration tests for private.NoServCommand and private.ServCommand (#17456) #17463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd (go-gitea#17456) Backport go-gitea#17456 modules/private/serv.go has two major functions that are missing testcases to ensure that Deploy and normal SSH keys work correctly. This PR adds some basic integration tests for these. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
backport-17456-v1.15
branch
from
97ac8b4
to
f4296fe
Compare
lunny
approved these changes
Oct 28, 2021
GiteaBot
added
the
lgtm/need 1
Merged
6543
approved these changes
Oct 28, 2021
GiteaBot
added
lgtm/done
|
Make L-G-T-M work. |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 28, 2021
Frontport go-gitea#17457 ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-28 * BUGFIXES * Prevent panic in serv.go with Deploy Keys (go-gitea#17434) (go-gitea#17435) * Fix CSV render error (go-gitea#17406) (go-gitea#17431) * Read expected buffer size (go-gitea#17409) (go-gitea#17430) * Ensure that restricted users can access repos for which they are members (go-gitea#17460) (go-gitea#17464) * Make commit-statuses popup show correctly (go-gitea#17447) (go-gitea#17466) * TESTING * Add integration tests for private.NoServCommand and private.ServCommand (go-gitea#17456) (go-gitea#17463)
zeripath
added a commit
that referenced
this pull request
Oct 28, 2021
Frontport #17457 ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-28 * BUGFIXES * Prevent panic in serv.go with Deploy Keys (#17434) (#17435) * Fix CSV render error (#17406) (#17431) * Read expected buffer size (#17409) (#17430) * Ensure that restricted users can access repos for which they are members (#17460) (#17464) * Make commit-statuses popup show correctly (#17447) (#17466) * TESTING * Add integration tests for private.NoServCommand and private.ServCommand (#17456) (#17463)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Frontport go-gitea#17457 ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-28 * BUGFIXES * Prevent panic in serv.go with Deploy Keys (go-gitea#17434) (go-gitea#17435) * Fix CSV render error (go-gitea#17406) (go-gitea#17431) * Read expected buffer size (go-gitea#17409) (go-gitea#17430) * Ensure that restricted users can access repos for which they are members (go-gitea#17460) (go-gitea#17464) * Make commit-statuses popup show correctly (go-gitea#17447) (go-gitea#17466) * TESTING * Add integration tests for private.NoServCommand and private.ServCommand (go-gitea#17456) (go-gitea#17463)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #17456
modules/private/serv.go has two major functions that are missing testcases to ensure
that Deploy and normal SSH keys work correctly.
This PR adds some basic integration tests for these.
Signed-off-by: Andrew Thornton art27@cantab.net