Fix login redirection links #17451
Merged
Fix login redirection links #17451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Oct 27, 2021
GiteaBot
added
the
lgtm/need 1
|
And if the login router could check if the redirect_to is itself is better. |
wxiaoguang
approved these changes
Oct 27, 2021
GiteaBot
added
lgtm/done
zeripath
approved these changes
Oct 28, 2021
FlyingOnion
reviewed
Oct 28, 2021
| @@ -192,7 +192,7 @@ | |||
| {{svg "octicon-person"}} {{.i18n.Tr "register"}} | |||
| </a> | |||
| {{end}} | |||
| <a class="item{{if .PageIsSignIn}} active{{end}}" rel="nofollow" href="{{AppSubUrl}}/user/login?redirect_to={{.CurrentURL}}"> | |||
| <a class="item{{if .PageIsSignIn}} active{{end}}" rel="nofollow" href="{{AppSubUrl}}/user/login{{if not .PageIsSignIn}}?redirect_to={{.CurrentURL}}{{end}}"> | |||
There was a problem hiding this comment.
Consider href="{{if not .PageIsSignIn}}{{AppSubUrl}}/user/login?redirect_to={{end}}{{.CurrentURL}}" to keep the original link?
There was a problem hiding this comment.
It sounds very cool, but it doesn't work:
package main
import (
"html/template"
"log"
"os"
)
func main() {
tplStr := `
<a href="{{.url}}">
<a href="?redirect={{.url}}">
<a href="{{if true}}?{{end}}redirect={{.url}}">
<a href="{{if not true}}?{{end}}redirect={{.url}}">
`
tpl := template.Must(template.New("tplName").Parse(tplStr))
err := tpl.Execute(os.Stdout, map[string]interface{}{"url":"/p?a=1&b=2#h", "true": true})
log.Printf("err = %v", err)
}
error: 2021/10/28 17:23:38 err = html/template:tplName:4:40: {{.url}} appears in an ambiguous context within a URL
Codecov Report
@@ Coverage Diff @@
## main #17451 +/- ##
=======================================
Coverage ? 45.48%
=======================================
Files ? 791
Lines ? 88697
Branches ? 0
=======================================
Hits ? 40341
Misses ? 41840
Partials ? 6516 Continue to review full report at Codecov.
|
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't add the
redirect_toargument if page is login.fixes #17421 fixes #17444