Skip to content

Fix history count failure #17351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2021
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 18, 2021

Fix an error when get history count

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 18, 2021
@lunny lunny closed this Oct 19, 2021
@lunny lunny deleted the lunny/fix_history_count branch October 19, 2021 01:01
@lunny lunny removed type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 19, 2021
@lunny lunny restored the lunny/fix_history_count branch October 21, 2021 05:37
@wxiaoguang wxiaoguang reopened this Oct 21, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 21, 2021
@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 21, 2021
@wxiaoguang
Copy link
Contributor

Thanks. I just realized that using column alias in HAVING is not SQL standard syntax and pgsql doesn't support it. So we need this PR.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17351 (c84e190) into main (83df0ca) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17351      +/-   ##
==========================================
- Coverage   45.27%   45.26%   -0.02%     
==========================================
  Files         788      788              
  Lines       88430    88430              
==========================================
- Hits        40041    40031      -10     
- Misses      41917    41918       +1     
- Partials     6472     6481       +9     
Impacted Files Coverage Δ
models/issues/content_history.go 69.16% <100.00%> (ø)
modules/notification/mail/mail.go 35.29% <0.00%> (-2.95%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
modules/queue/queue_channel.go 95.00% <0.00%> (-1.67%) ⬇️
modules/notification/ui/ui.go 60.86% <0.00%> (-1.45%) ⬇️
models/notification.go 65.28% <0.00%> (-0.88%) ⬇️
models/issue_comment.go 51.31% <0.00%> (-0.59%) ⬇️
services/pull/pull.go 41.78% <0.00%> (-0.41%) ⬇️
routers/api/v1/repo/pull.go 29.35% <0.00%> (+0.51%) ⬆️
modules/queue/workerpool.go 50.38% <0.00%> (+1.14%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83df0ca...c84e190. Read the comment docs.

@wxiaoguang wxiaoguang merged commit f3c7f10 into go-gitea:main Oct 21, 2021
@lunny lunny deleted the lunny/fix_history_count branch October 21, 2021 11:34
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants