Nicely handle missing user in collaborations #17049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to have a collaboration in a repository which refers to a no-longer existing user. This causes the repository transfer to fail with an unusual error. This PR makes `repo.getCollaborators()` nicely handle the missing user by ghosting the collaboration but also adds consistency check. It also adds an Access consistency check. Fix go-gitea#17044 Signed-off-by: Andrew Thornton <art27@cantab.net>
delvh
reviewed
Sep 14, 2021
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## main #17049 +/- ##
==========================================
+ Coverage 45.22% 45.25% +0.02%
==========================================
Files 766 766
Lines 86716 86647 -69
==========================================
- Hits 39217 39208 -9
+ Misses 41148 41090 -58
+ Partials 6351 6349 -2
Continue to review full report at Codecov.
|
lafriks
approved these changes
Sep 15, 2021
GiteaBot
added
lgtm/need 1
delvh
reviewed
Sep 15, 2021
KN4CK3R
reviewed
Sep 16, 2021
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
wxiaoguang
approved these changes
Sep 26, 2021
GiteaBot
added
lgtm/done
|
make lgtm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Sep 27, 2021
Backport go-gitea#17049 It is possible to have a collaboration in a repository which refers to a no-longer existing user. This causes the repository transfer to fail with an unusual error. This PR makes `repo.getCollaborators()` nicely handle the missing user by ghosting the collaboration but also adds consistency check. It also adds an Access consistency check. Fix go-gitea#17044 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
zeripath
added a commit
that referenced
this pull request
Sep 28, 2021
Backport #17049 It is possible to have a collaboration in a repository which refers to a no-longer existing user. This causes the repository transfer to fail with an unusual error. This PR makes `repo.getCollaborators()` nicely handle the missing user by ghosting the collaboration but also adds consistency check. It also adds an Access consistency check. Fix #17044 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to have a collaboration in a repository which refers to a no-longer
existing user. This causes the repository transfer to fail with an unusual error.
This PR makes
repo.getCollaborators()nicely handle the missing user by ghostingthe collaboration but also adds consistency check. It also adds an
Access consistency check.
Fix #17044
Signed-off-by: Andrew Thornton art27@cantab.net