Add integration tests for commit table and status icons

integrations/repo_commits_test.go

@@ -0,0 +1,95 @@
+// Copyright 2017 The Gitea Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE file.
+
+package integrations
+
+import (
+	"bytes"
+	"net/http"
+	"path"
+	"testing"
+
+	//"fmt"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestRepoCommits(t *testing.T) {
+	prepareTestEnv(t)
+
+	session := loginUser(t, "user2", "password")
+
+	// Request repository commits page
+	req, err := http.NewRequest("GET", "/user2/repo1/commits/master", nil)
+	assert.NoError(t, err)
+	resp := session.MakeRequest(t, req)
+	assert.EqualValues(t, http.StatusOK, resp.HeaderCode)
+
+	doc, err := NewHtmlParser(resp.Body)
+	assert.NoError(t, err)
+	commitURL, exists := doc.doc.Find("#commits-table tbody tr td.sha a").Attr("href")
+	assert.True(t, exists)
+	assert.NotEmpty(t, commitURL)
+}
+
+func doTestRepoCommitWithStatus(t *testing.T, state string, classes ...string) {
+	prepareTestEnv(t)
+
+	session := loginUser(t, "user2", "password")
+
+	// Request repository commits page
+	req, err := http.NewRequest("GET", "/user2/repo1/commits/master", nil)
+	assert.NoError(t, err)
+	resp := session.MakeRequest(t, req)
+	assert.EqualValues(t, http.StatusOK, resp.HeaderCode)
+
+	doc, err := NewHtmlParser(resp.Body)
+	assert.NoError(t, err)
+	// Get first commit URL
+	commitURL, exists := doc.doc.Find("#commits-table tbody tr td.sha a").Attr("href")
+	assert.True(t, exists)
+	assert.NotEmpty(t, commitURL)
+
+	// Call API to add status for commit
+	req, err = http.NewRequest("POST", "/api/v1/repos/user2/repo1/statuses/"+path.Base(commitURL),
+		bytes.NewBufferString("{\"state\":\""+state+"\", \"target_url\": \"http://test.ci/\", \"description\": \"\", \"context\": \"testci\"}"))
+
+	assert.NoError(t, err)
+	req.Header.Add("Content-Type", "application/json")
+	resp = session.MakeRequest(t, req)
+	assert.EqualValues(t, http.StatusCreated, resp.HeaderCode)
+
+	req, err = http.NewRequest("GET", "/user2/repo1/commits/master", nil)
+	assert.NoError(t, err)
+	resp = session.MakeRequest(t, req)
+	assert.EqualValues(t, http.StatusOK, resp.HeaderCode)
+
+	doc, err = NewHtmlParser(resp.Body)
+	assert.NoError(t, err)
+	// Check if commit status is displayed in message column
+	sel := doc.doc.Find("#commits-table tbody tr td.message i.commit-status")
+	assert.Equal(t, sel.Length(), 1)
+	for _, class := range classes {
+		assert.True(t, sel.HasClass(class))
+	}
+}
+
+func TestRepoCommitsWithStatusPending(t *testing.T) {
+	doTestRepoCommitWithStatus(t, "pending", "circle", "yellow")
+}
+
+func TestRepoCommitsWithStatusSuccess(t *testing.T) {
+	doTestRepoCommitWithStatus(t, "success", "check", "green")
+}
+
+func TestRepoCommitsWithStatusError(t *testing.T) {
+	doTestRepoCommitWithStatus(t, "error", "warning", "red")
+}
+
+func TestRepoCommitsWithStatusFailure(t *testing.T) {
+	doTestRepoCommitWithStatus(t, "failure", "remove", "red")
+}
+
+func TestRepoCommitsWithStatusWarning(t *testing.T) {
+	doTestRepoCommitWithStatus(t, "warning", "warning", "sign", "yellow")
+}

templates/repo/commits_table.tmpl

@@ -62,19 +62,19 @@
 						<td class="message collapsing">
 							<span class="has-emoji{{if gt .ParentCount 1}} grey text{{end}}">{{RenderCommitMessage false .Summary $.RepoLink $.Repository.ComposeMetas}}</span>
 							{{if eq .State "pending"}}
-							<i class="circle icon yellow"></i>
+							<i class="commit-status circle icon yellow"></i>
 							{{end}}
 							{{if eq .State "success"}}
-							<i class="check icon green"></i>
+							<i class="commit-status check icon green"></i>
 							{{end}}
 							{{if eq .State "error"}}
-							<i class="warning icon red"></i>
+							<i class="commit-status warning icon red"></i>
 							{{end}}
 							{{if eq .State "failure"}}
-							<i class="remove icon red"></i>
+							<i class="commit-status remove icon red"></i>
 							{{end}}
 							{{if eq .State "warning"}}
-							<i class="warning sign icon yellow"></i>
+							<i class="commit-status warning sign icon yellow"></i>
 							{{end}}
 						</td>
 						<td class="grey text right aligned">{{TimeSince .Author.When $.Lang}}</td>