Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember diff view style #163

Merged
merged 1 commit into from
Nov 13, 2016
Merged

Remember diff view style #163

merged 1 commit into from
Nov 13, 2016

Conversation

andreynering
Copy link
Contributor

Whether the user choose to see the unified or split view, remember this option for the next time.

@andreynering andreynering added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Nov 12, 2016
@thibaultmeyer
Copy link
Contributor

LGTM

1 similar comment
@tboerger
Copy link
Member

LGTM

@tboerger tboerger added this to the 1.0.0 milestone Nov 13, 2016
@lunny lunny merged commit 739f07c into go-gitea:master Nov 13, 2016
@andreynering andreynering deleted the gitea/remember-diff-view-style branch November 13, 2016 10:42
@stevenroose
Copy link

Seems strange to store this as a string.. Any specific reason it would not be stored as an int value tied to an enum?

@andreynering
Copy link
Contributor Author

@stevenroose I understand... I usually use a single letter for enums (would be U for unified and S for split). But here, I tried to use the existing convetion Gogs used.

@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Apr 29, 2017
Merge changes from upstream (up to v1.1.0)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants