Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tagger can be empty, as can Commit and Author - tolerate this (#15835) #15839

Merged
merged 2 commits into from
May 12, 2021
Merged

Tagger can be empty, as can Commit and Author - tolerate this (#15835) #15839

merged 2 commits into from
May 12, 2021

Commits on May 12, 2021

  1. Tagger can be empty, as can Commit and Author - tolerate this (go-git… 

    …ea#15835)

Backport go-gitea#15835

Unfortunately some old repositories can have tags with empty Tagger, Commit
or Author. Go-Git variants will always have empty values for these whereas
the native git variant leaves them at nil. The simplest solution is just to
always have these set to empty Signatures.

v156 migration also makes the incorrect assumption that these cannot be empty.
Therefore add some handling to this and add logging and adjust broken
logging elsewhere in this migration.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed May 12, 2021
    Configuration menu
    Copy the full SHA
    361d638 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/v1.14' into backport-15835-v1.14

    @6543
    6543 authored May 12, 2021
    Configuration menu
    Copy the full SHA
    02dd7bf View commit details
    Browse the repository at this point in the history