Skip to content

Tests should use test files #15801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
6543 merged 2 commits into from
May 9, 2021
Merged

Tests should use test files #15801

6543 merged 2 commits into from
May 9, 2021

Conversation

@6543
Copy link
Member

@6543 6543 commented May 9, 2021

as title

@6543 6543 added this to the 1.15.0 milestone May 9, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 9, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021 •
edited
Loading

Codecov Report

Merging #15801 (c3357f0) into main (a98c09d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15801      +/-   ##
==========================================
- Coverage   43.98%   43.97%   -0.01%     
==========================================
  Files         678      678              
  Lines       82024    82024              
==========================================
- Hits        36076    36073       -3     
- Misses      40073    40076       +3     
  Partials     5875     5875
Impacted Files Coverage Δ
modules/queue/queue_bytefifo.go 81.20% <0.00%> (-2.02%) ⬇️
models/gpg_key.go 53.51% <0.00%> (-0.57%) ⬇️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98c09d...c3357f0. Read the comment docs.

@6543
Copy link
Member Author

6543 commented May 9, 2021

🚀

@6543 6543 merged commit 4ea0b46 into go-gitea:main May 9, 2021
@6543 6543 deleted the improve_git-repo-test branch May 9, 2021 15:20
6543 added a commit to 6543-forks/gitea that referenced this pull request May 9, 2021
@6543
Tests should use test files (go-gitea#15801)
c481d68
@6543 6543 mentioned this pull request May 9, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label May 9, 2021
@6543
Copy link
Member Author

6543 commented May 9, 2021

-> #15806

lunny pushed a commit that referenced this pull request May 9, 2021
@6543
Tests should use test files (#15801) (#15806)
c57e908
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@6543 @AbdulrhmnGhanem
Tests should use test files (go-gitea#15801)
1c27510
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/testing

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@6543 @codecov-commenter @lunny @KN4CK3R @GiteaBot