Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement delete release attachments and update release attachments' name (#14130) #15666

Merged
merged 3 commits into from
May 3, 2021
Merged

Implement delete release attachments and update release attachments' name (#14130) #15666

merged 3 commits into from
May 3, 2021

Conversation

kdumontnu
Copy link
Contributor

Backport #14130

fix #677

Co-authored-by: lunny

@lunny @kdumontnu
Implement delete release attachments and update release attachments' …
5edc247 
…name (go-gitea#14130)

* Implement delete release attachment

* Add attachments on release edit page

* Fix bug

* Finish del release attachments

* Fix frontend lint

* Fix tests

* Support edit release attachments

* Added tests

* Remove the unnecessary parameter isCreate from UpdateReleaseOrCreatReleaseFromTag

* Rename UpdateReleaseOrCreatReleaseFromTag to UpdateRelease

* Fix middle align
@zeripath
Copy link
Contributor

Not sure about this - it's technically a feature - but I know we tend to have relatively slow turnarounds for 1.15

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2021
@kdumontnu
Copy link
Contributor Author

Not sure about this - it's technically a feature - but I know we tend to have relatively slow turnarounds for 1.15

Understood - I'm perfectly happy either way. We should be diligent on not adding breaking changes & new features. The reason I thought this might be appropriate is:

  • Not being able to delete attachments is (imo) such a large missing piece of releases that it borders on being a bug (making releases unusable)
  • It has been merged into master for over a month (which is why I originally thought it had been in 1.14)

If you're uncomfortable with it, lets close this and work on v1.15 😄

@lunny
Copy link
Member

lunny commented Apr 30, 2021

Since there is no migration and break thing, I think it's OK.

@6543 6543 mentioned this pull request May 2, 2021
Closed
6 tasks
@6543 6543 added the type/enhancement An improvement of existing functionality label May 2, 2021
@6543 6543 mentioned this pull request May 2, 2021
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2021
@6543 6543 requested a review from zeripath May 2, 2021 16:37
@6543
Copy link
Member

6543 commented May 2, 2021

@kdumontnu can you update the branch please :)

@6543 6543 added this to the 1.14.2 milestone May 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2021
@techknowlogick techknowlogick merged commit cead819 into go-gitea:release/v1.14 May 3, 2021
@kdumontnu kdumontnu deleted the backport-14130-v1.14 branch May 3, 2021 23:46
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.2
Development

Successfully merging this pull request may close these issues.
6 participants
@kdumontnu @zeripath @lunny @6543 @techknowlogick @GiteaBot