Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xorm log stack level #15285

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Fix xorm log stack level #15285

merged 2 commits into from
Apr 5, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 5, 2021 •
edited
Loading

Before it will show the file core/db.go which is the file location of xorm package, now it will mostly display the location on Gitea package.

6543
6543 approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use-full!

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 5, 2021
@6543 6543 added the type/bug label Apr 5, 2021
@6543 6543 added this to the 1.15.0 milestone Apr 5, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2021
@zeripath
Copy link
Contributor

zeripath commented Apr 5, 2021

Great idea

@zeripath zeripath merged commit fe3dced into go-gitea:master Apr 5, 2021
@lunny lunny deleted the lunny/fix_xorm_log_stack_level branch April 5, 2021 09:17
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Apr 7, 2021
@lunny @6543
Fix xorm log stack level (go-gitea#15285)
38ae234
@6543 6543 mentioned this pull request Apr 7, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Apr 7, 2021
@6543
Copy link
Member

6543 commented Apr 7, 2021

Backport -> #15316

zeripath pushed a commit that referenced this pull request Apr 7, 2021
@6543 @lunny
Fix xorm log stack level (#15285) (#15316)
80b5526 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @zeripath @6543 @a1012112796 @GiteaBot