Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should run RetrieveRepoMetas() for empty pr #15187

Merged
merged 1 commit into from
Mar 29, 2021
Merged

should run RetrieveRepoMetas() for empty pr #15187

merged 1 commit into from
Mar 29, 2021

Conversation

a1012112796
Copy link
Member

after #12543, empty pull requst is allowed. so still need provide information for it. But I fogot to chek it.
fell sorry for my fault.

ref:

gitea/routers/repo/compare.go

Lines 553 to 558 in 3416e2a

if !nothingToCompare {
// Setup information for new form.
RetrieveRepoMetas(ctx, ctx.Repo.Repository, true)
if ctx.Written() {
return
}

fix #15185

@a1012112796
should run RetrieveRepoMetas() for empty pr
35a2fef 
Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 29, 2021
@lafriks lafriks added this to the 1.15.0 milestone Mar 29, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2021
@zeripath zeripath merged commit 2b9e0b4 into go-gitea:master Mar 29, 2021
@zeripath
Copy link
Contributor

Please send backport

@a1012112796 a1012112796 deleted the fix_empty_pr branch March 29, 2021 13:52
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Mar 29, 2021
@a1012112796
should run RetrieveRepoMetas() for empty pr (go-gitea#15187)
cca3761 
Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 mentioned this pull request Mar 29, 2021
Merged
@a1012112796 a1012112796 added the backport/done All backports for this PR have been created label Mar 29, 2021
zeripath pushed a commit that referenced this pull request Mar 29, 2021
@a1012112796
should run RetrieveRepoMetas() for empty pr (#15187) (#15190)
6130882 
Signed-off-by: a1012112796 <1012112796@qq.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

When creating a pr the organization's labels are not available
4 participants
@a1012112796 @zeripath @lafriks @GiteaBot