Add repo mirror sync API endpoint #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cez81
changed the title
appleboy
approved these changes
Apr 18, 2017
lunny
added
modifies/api
|
LGTM Small concise PRs that does one thing only ❤️ |
tboerger
added
the
lgtm/need 1
bkcsoft
suggested changes
Apr 19, 2017
routers/api/v1/repo/repo.go
Outdated
| } | ||
|
|
||
| go models.MirrorQueue.Add(repo.ID) | ||
| ctx.Status(202) |
There was a problem hiding this comment.
I'd go with 200 or 201 here. 202 Accepted doesn't make any sense to me :)
There was a problem hiding this comment.
I found many place 202 and don't know the difference between 200, 201 and 202.
bkcsoft
approved these changes
Apr 19, 2017
|
LGTM wait CI build. |
|
Let L-G-T-M WORK! |
tboerger
added
lgtm/done
|
ready to merge (but still lacks unit test for being considered a perfect PR :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at the API, please bear with me :)
Add mirror sync endpoint to the Api adopted from Gogs.
/repos/:owner/:repo/mirror-sync