Skip to content

[Refactor] remove possible resource leak #15067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2021
Merged

[Refactor] remove possible resource leak #15067

merged 3 commits into from
Mar 20, 2021

Conversation

@6543
Copy link
Member

@6543 6543 commented Mar 20, 2021

as title

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 20, 2021
@6543 6543 added this to the 1.15.0 milestone Mar 20, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 20, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 20, 2021
@lunny
Copy link
Member

lunny commented Mar 20, 2021

lint should be fixed.

zeripath
zeripath reviewed Mar 20, 2021
View reviewed changes
@6543 6543 added the type/bug label Mar 20, 2021
@lunny
Copy link
Member

lunny commented Mar 20, 2021

make L-G-T-M work.

@lunny lunny merged commit 78e8f62 into go-gitea:master Mar 20, 2021
@6543 6543 deleted the refactor_Possible-Resource-Leak branch March 20, 2021 16:54
6543 added a commit to 6543-forks/gitea that referenced this pull request Mar 21, 2021
@6543 @zeripath
[Refactor] remove possible resource leak (go-gitea#15067)
0c0e9a1 
* move "copy uploaded lfs files 2 repo" to own function for "defer file.Close()"

* rm type overload

* Update modules/repofiles/upload.go

Co-authored-by: zeripath <art27@cantab.net>
@6543 6543 mentioned this pull request Mar 21, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Mar 21, 2021
6543 added a commit that referenced this pull request Mar 21, 2021
@6543 @zeripath
Remove possible resource leak (#15067) (#15082)
d770cc9 
* move "copy uploaded lfs files 2 repo" to own function for "defer file.Close()"

* rm type overload

Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@6543 @lunny @zeripath @lafriks @GiteaBot