Skip to content

Fix bug when upload on web #15042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 19, 2021
Merged

Fix bug when upload on web #15042

merged 6 commits into from
Mar 19, 2021

Conversation

@lunny
Copy link
Member

@lunny lunny commented Mar 19, 2021

Fix #13611

@lunny lunny mentioned this pull request Mar 19, 2021
Closed
@lunny lunny added the backport/done All backports for this PR have been created label Mar 19, 2021
@lunny lunny mentioned this pull request Mar 19, 2021
Merged
1 task
kdumontnu
kdumontnu reviewed Mar 19, 2021
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2021
6543
6543 reviewed Mar 19, 2021
View reviewed changes
kdumontnu
kdumontnu approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2021
@kdumontnu
Copy link
Contributor

kdumontnu commented Mar 19, 2021

CI looks like legitimate failure

zeripath and others added 2 commits March 19, 2021 20:14
@zeripath
add missing return
de68390 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@6543
Merge branch 'master' into lunny/fix_upload
888832d
@6543 6543 added this to the 1.14.0 milestone Mar 19, 2021
@techknowlogick techknowlogick modified the milestones: 1.14.0, 1.15.0 Mar 19, 2021
@6543 6543 merged commit cf54950 into go-gitea:master Mar 19, 2021
6543 added a commit to 6543-forks/gitea that referenced this pull request Mar 19, 2021
@lunny @6543 @zeripath
Fix bug when upload on web (go-gitea#15042)
5c1ffd7 
* Fix bug when upload on web

* move into own function

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
@6543 6543 mentioned this pull request Mar 19, 2021
Merged
6543 added a commit to 6543-forks/gitea that referenced this pull request Mar 19, 2021
@lunny @6543 @zeripath
Fix bug when upload on web (go-gitea#15042)
6e0d03f 
* Fix bug when upload on web

* move into own function

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
@6543 6543 mentioned this pull request Mar 19, 2021
Merged
@6543
Copy link
Member

6543 commented Mar 19, 2021

Backports:

@lunny lunny deleted the lunny/fix_upload branch March 20, 2021 01:37
lunny added a commit that referenced this pull request Mar 20, 2021
@6543 @lunny @zeripath
Fix bug when upload on web (#15042) (#15055)
a461d90 
* Fix bug when upload on web

* move into own function

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>
lunny added a commit that referenced this pull request Mar 20, 2021
@6543 @lunny @zeripath
Fix bug when upload on web (#15042) (#15054)
7b464fa 
* Fix bug when upload on web

* move into own function

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

+2 more reviewers

@garfeng garfeng garfeng left review comments

@kdumontnu kdumontnu kdumontnu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

remove upload: remove

8 participants

@lunny @kdumontnu @6543 @garfeng @jolheiser @techknowlogick @GiteaBot @zeripath