Skip to content

API: fix set milestone on PR creation #14981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2021
Merged

API: fix set milestone on PR creation #14981

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d19a93
API: fix set milestone on PR creation
noerw Mar 13, 2021
748da86
add tests
noerw Mar 13, 2021
7402d82
fix expected status codes
noerw Mar 13, 2021
1d1c131
Merge branch 'master' into fix-api-pr-milestone
6543 Mar 13, 2021
1c8db09
fix tests
6543 Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions routers/api/v1/repo/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,6 @@ func CreatePullRequest(ctx *context.APIContext) {
var (
repo = ctx.Repo.Repository
labelIDs []int64
assigneeID int64
milestoneID int64
)

Expand Down Expand Up @@ -356,7 +355,7 @@ func CreatePullRequest(ctx *context.APIContext) {
}

if form.Milestone > 0 {
milestone, err := models.GetMilestoneByRepoID(ctx.Repo.Repository.ID, milestoneID)
milestone, err := models.GetMilestoneByRepoID(ctx.Repo.Repository.ID, form.Milestone)
if err != nil {
if models.IsErrMilestoneNotExist(err) {
ctx.NotFound()
Expand All @@ -380,7 +379,6 @@ func CreatePullRequest(ctx *context.APIContext) {
PosterID: ctx.User.ID,
Poster: ctx.User,
MilestoneID: milestoneID,
AssigneeID: assigneeID,
IsPull: true,
Content: form.Body,
DeadlineUnix: deadlineUnix,
Expand Down