Skip to content

Conversation

@zeripath
Copy link
Contributor

When using HCaptcha on link account pages the site key needs to be passed
in. This PR ensures that HCaptchaSiteKey is set in the data.

Fix #14766

Signed-off-by: Andrew Thornton art27@cantab.net

When using HCaptcha on link account pages the site key needs to be passed
in. This PR ensures that HCaptchaSiteKey is set in the data.

Fix go-gitea#14766

Signed-off-by: Andrew Thornton <art27@cantab.net>
@codecov-io
Copy link

Codecov Report

Merging #14834 (24afae8) into master (cf29cb3) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14834   +/-   ##
=======================================
  Coverage   42.22%   42.22%           
=======================================
  Files         771      771           
  Lines       82181    82188    +7     
=======================================
+ Hits        34702    34706    +4     
- Misses      41826    41830    +4     
+ Partials     5653     5652    -1     
Impacted Files Coverage Δ
routers/user/auth.go 12.20% <0.00%> (-0.04%) ⬇️
models/repo_list.go 77.87% <0.00%> (-0.89%) ⬇️
models/repo.go 52.57% <0.00%> (+0.16%) ⬆️
services/pull/pull.go 42.64% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf29cb3...24afae8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 030646e into go-gitea:master Feb 28, 2021
@zeripath zeripath deleted the fix-14766-set-hcaptchasitekey branch February 28, 2021 22:19
@zeripath
Copy link
Contributor Author

Happy for anyone to send backport

@zeripath
Copy link
Contributor Author

(or I'll do it at some point tomorrow)

zeripath added a commit to zeripath/gitea that referenced this pull request Mar 1, 2021
Backport go-gitea#14834

When using HCaptcha on link account pages the site key needs to be passed
in. This PR ensures that HCaptchaSiteKey is set in the data.

Fix go-gitea#14766

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 1, 2021
6543 pushed a commit that referenced this pull request Mar 1, 2021
Backport #14834

When using HCaptcha on link account pages the site key needs to be passed
in. This PR ensures that HCaptchaSiteKey is set in the data.

Fix #14766

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hCaptcha failed to initialize on link registration page

5 participants