Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double alert in oauth2 application edit view #14764

Merged
merged 4 commits into from
Feb 22, 2021

Conversation

a1012112796
Copy link
Member

the {{template "base/alert" .}} hase been added in line 5.

Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 21, 2021
@lunny
Copy link
Member

lunny commented Feb 21, 2021

Does this affect v1.13?

@lunny lunny added the type/bug label Feb 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 21, 2021
@zeripath zeripath added this to the 1.14.0 milestone Feb 21, 2021
@techknowlogick techknowlogick added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.13 labels Feb 21, 2021
@techknowlogick
Copy link
Member

@lunny yes

@6543
Copy link
Member

6543 commented Feb 22, 2021

.

@6543 6543 merged commit cd8b2f3 into go-gitea:master Feb 22, 2021
@a1012112796 a1012112796 deleted the fix-double-alert branch February 22, 2021 04:38
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Feb 22, 2021
Signed-off-by: a1012112796 <1012112796@qq.com>
@6543 6543 removed the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 22, 2021
6543 pushed a commit that referenced this pull request Feb 22, 2021
Signed-off-by: a1012112796 <1012112796@qq.com>
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 1, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants