Skip to content

Render links for commit hashes followed by comma #14224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2021
Merged

Render links for commit hashes followed by comma #14224

merged 1 commit into from
Jan 3, 2021

Conversation

@nuno-silva
Copy link
Contributor

@nuno-silva nuno-silva commented Jan 3, 2021

Regex test cases: https://regex101.com/r/mVbPxM/2/

fixes #14223

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 3, 2021
@lunny lunny added this to the 1.14.0 milestone Jan 3, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 3, 2021
@codecov-io
Copy link

codecov-io commented Jan 3, 2021

Codecov Report

Merging #14224 (a89b3a3) into master (7576e37) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14224      +/-   ##
==========================================
+ Coverage   41.96%   41.98%   +0.01%     
==========================================
  Files         735      735              
  Lines       78928    78928              
==========================================
+ Hits        33126    33138      +12     
+ Misses      40347    40340       -7     
+ Partials     5455     5450       -5
Impacted Files Coverage Δ
modules/markup/html.go 78.54% <ø> (ø)
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
modules/git/repo_language_stats_nogogit.go 61.70% <0.00%> (+4.25%) ⬆️
modules/git/tree_nogogit.go 69.56% <0.00%> (+8.69%) ⬆️
modules/indexer/stats/db.go 60.00% <0.00%> (+12.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7576e37...a89b3a3. Read the comment docs.

@lunny lunny merged commit 44ff1d6 into go-gitea:master Jan 3, 2021
@lunny
Copy link
Member

lunny commented Jan 3, 2021

Please send back port to release/v1.13

nuno-silva added a commit to nuno-silva/gitea that referenced this pull request Jan 3, 2021
@nuno-silva
Render links for commit hashes followed by comma (go-gitea#14224)
a565f66 
Regex test cases: https://regex101.com/r/mVbPxM/2/

fixes go-gitea#14223
@nuno-silva nuno-silva mentioned this pull request Jan 3, 2021
Merged
@nuno-silva nuno-silva deleted the issue-14223 branch January 3, 2021 16:22
@6543 6543 added the backport/done All backports for this PR have been created label Jan 3, 2021
6543 pushed a commit that referenced this pull request Jan 3, 2021
@nuno-silva
Render links for commit hashes followed by comma (#14224) (#14227)
4be59eb 
Regex test cases: https://regex101.com/r/mVbPxM/2/

fixes #14223
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

Links for commit hashes ending in comma are not rendered

6 participants

@nuno-silva @codecov-io @lunny @lafriks @GiteaBot @6543