Skip to content

When visit /favicon.ico and the static file is not exist return 404 but not continue to handle the route #14211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2021
Merged

When visit /favicon.ico and the static file is not exist return 404 but not continue to handle the route #14211

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c53e828
When visit /favicon.ico but the static file is not exist return 404 b…
lunny Jan 1, 2021
b6fd8a9
Merge branch 'master' into lunny/fix_favicon_redirect
techknowlogick Jan 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/public/public.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ var KnownPublicEntries = []string{
"js",
"serviceworker.js",
"vendor",
"favicon.ico",
}

// Custom implements the macaron static handler for serving custom assets.
Expand Down