Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that search term and page are not lost on adoption page-turn #14133

Merged
merged 3 commits into from
Dec 24, 2020
Merged

Ensure that search term and page are not lost on adoption page-turn #14133

merged 3 commits into from
Dec 24, 2020

Conversation

zeripath
Copy link
Contributor

Fix #14111

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Ensure that search term and page are not lost on adoption page-turn
52cbb5a 
Fix go-gitea#14111

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Dec 23, 2020
@codecov-io
Copy link

Codecov Report

Merging #14133 (52cbb5a) into master (e0c753e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14133      +/-   ##
==========================================
- Coverage   42.37%   42.35%   -0.02%     
==========================================
  Files         726      726              
  Lines       77839    77844       +5     
==========================================
- Hits        32982    32969      -13     
- Misses      39447    39461      +14     
- Partials     5410     5414       +4
Impacted Files Coverage Δ
routers/admin/repos.go 0.00% <0.00%> (ø)
modules/git/tree_entry_nogogit.go 87.50% <0.00%> (-6.25%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/queue/manager.go 62.13% <0.00%> (-2.96%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 48.90% <0.00%> (-0.73%) ⬇️
routers/api/v1/repo/pull.go 24.84% <0.00%> (-0.61%) ⬇️
services/pull/pull.go 42.35% <0.00%> (-0.51%) ⬇️
models/issue_comment.go 52.41% <0.00%> (-0.31%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c753e...52cbb5a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 23, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 24, 2020
@lunny
Copy link
Member

lunny commented Dec 24, 2020

make L-G-T-M work

@lunny lunny merged commit fa2e349 into go-gitea:master Dec 24, 2020
@zeripath zeripath deleted the fix-14111-unadopted-page-turn-needs-search-true branch December 24, 2020 16:18
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 24, 2020
@zeripath
Ensure that search term and page are not lost on adoption page-turn (g…
3695f16 
…o-gitea#14133)

Backport go-gitea#14133

Fix go-gitea#14111

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Dec 24, 2020
Merged
zeripath added a commit that referenced this pull request Dec 24, 2020
@zeripath
Ensure that search term and page are not lost on adoption page-turn (#…
bf1441b 
…14133) (#14143)

Backport #14133

Fix #14111

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Dec 26, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Error pagination on Adopt repositories admin page
6 participants
@zeripath @codecov-io @lunny @silverwind @lafriks @GiteaBot