Always wait for the cmd to finish #14006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After cancelling the context we still need to wait for the command to finish otherwise zombie processes may occur Fix go-gitea#13987 Signed-off-by: Andrew Thornton <art27@cantab.net>
jolheiser
reviewed
Dec 15, 2020
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #14006 +/- ##
==========================================
- Coverage 42.23% 42.12% -0.11%
==========================================
Files 710 710
Lines 77261 77259 -2
==========================================
- Hits 32629 32544 -85
- Misses 39266 39363 +97
+ Partials 5366 5352 -14
Continue to review full report at Codecov.
|
lunny
approved these changes
Dec 16, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Dec 17, 2020
GiteaBot
added
lgtm/done
Member
|
🚀 |
Member
|
@zeripath pleace backport :) |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Dec 17, 2020
Backport go-gitea#14006 After cancelling the context we still need to wait for the command to finish otherwise zombie processes may occur Fix go-gitea#13987 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de>
6543
pushed a commit
that referenced
this pull request
Dec 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After cancelling the context we still need to wait for the
command to finish otherwise zombie processes may occur
Fix #13987
Signed-off-by: Andrew Thornton art27@cantab.net