-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Quote Reply button on review diff #13830
Conversation
Is there a |
0d40327
to
f104773
Compare
Codecov Report
@@ Coverage Diff @@
## master #13830 +/- ##
==========================================
+ Coverage 42.13% 42.16% +0.02%
==========================================
Files 708 708
Lines 77193 77193
==========================================
+ Hits 32523 32545 +22
+ Misses 39318 39298 -20
+ Partials 5352 5350 -2
Continue to review full report at Codecov.
|
@jpraet would be nice if you send a backport |
-> #13898 |
Fixes #13762
This fixes the "Quote Reply" button on the code review diff page.
I also noticed the focusing of the text area wasn't working for the "Quote Reply" as well as "Edit". Something else is stealing the focus. I tried to work around that with
event.stopPropagation()
at first, but that caused other issues. Once I wrapped the focus code in asetTimeout(..., 0)
it started working. Might not be the cleanest solution?