Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Use Process Manager to create own Context #13792

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 2, 2020

as title :)

now migration processes will show up in http://localhost:3000/admin/monitor

@6543 6543 added the type/enhancement An improvement of existing functionality label Dec 2, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 2, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 2, 2020
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool So I think we can do even better here actually - if we get the process manager to be the one to make the contexts we can get it to stick the PID in the data context, so we can either avoid registering child processes or better display child processes with their parents.

however, this is a great first step towards moving to make these things cancellable from outside process

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2020
@6543 6543 added the backport/done All backports for this PR have been created label Dec 2, 2020
@6543
Copy link
Member Author

6543 commented Dec 2, 2020

Backport: #13793

@codecov-io
Copy link

Codecov Report

Merging #13792 (2a0ab2d) into master (fd1c351) will decrease coverage by 0.10%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13792      +/-   ##
==========================================
- Coverage   42.24%   42.13%   -0.11%     
==========================================
  Files         707      707              
  Lines       77123    77130       +7     
==========================================
- Hits        32577    32500      -77     
- Misses      39181    39288     +107     
+ Partials     5365     5342      -23     
Impacted Files Coverage Δ
modules/git/git.go 40.00% <ø> (ø)
modules/repository/repo.go 43.31% <66.66%> (ø)
modules/task/migrate.go 31.42% <80.00%> (+5.27%) ⬆️
modules/git/repo.go 46.23% <100.00%> (+1.05%) ⬆️
modules/migrations/gitea_uploader.go 6.72% <100.00%> (ø)
models/issue_comment.go 43.50% <0.00%> (-9.22%) ⬇️
modules/notification/ui/ui.go 84.72% <0.00%> (-8.34%) ⬇️
modules/notification/mail/mail.go 33.33% <0.00%> (-5.75%) ⬇️
modules/git/commit.go 49.67% <0.00%> (-3.95%) ⬇️
modules/notification/base/null.go 74.28% <0.00%> (-2.86%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1c351...5a97607. Read the comment docs.

@6543
Copy link
Member Author

6543 commented Dec 2, 2020

🚀

@zeripath zeripath merged commit 2b4a08e into go-gitea:master Dec 2, 2020
@6543 6543 deleted the migrations_run-in-own-process-context branch December 2, 2020 18:41
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants