-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Settings: Ignore empty language codes & validate #13755
Merged
lafriks
merged 6 commits into
go-gitea:master
from
6543-forks:user-settings-ignore-incorect-lang-value
Dec 4, 2020
Merged
User Settings: Ignore empty language codes & validate #13755
lafriks
merged 6 commits into
go-gitea:master
from
6543-forks:user-settings-ignore-incorect-lang-value
Dec 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13755 +/- ##
==========================================
- Coverage 42.25% 42.14% -0.12%
==========================================
Files 708 708
Lines 77168 77173 +5
==========================================
- Hits 32608 32522 -86
- Misses 39196 39303 +107
+ Partials 5364 5348 -16
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 30, 2020
tests seems to fail now |
6543
force-pushed
the
user-settings-ignore-incorect-lang-value
branch
from
December 1, 2020 16:29
a5453fe
to
7584d19
Compare
6543
commented
Dec 1, 2020
zeripath
approved these changes
Dec 1, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Dec 1, 2020
6543
force-pushed
the
user-settings-ignore-incorect-lang-value
branch
from
December 3, 2020 02:04
9153147
to
531f7a3
Compare
6543
force-pushed
the
user-settings-ignore-incorect-lang-value
branch
from
December 3, 2020 02:20
531f7a3
to
ef6429d
Compare
6543
force-pushed
the
user-settings-ignore-incorect-lang-value
branch
from
December 3, 2020 02:36
ef6429d
to
c0fd164
Compare
@lafriks fixed :) |
6543
changed the title
User Settings: Ignore incorect language codes
User Settings: Ignore empty language codes & validate
Dec 3, 2020
mrsdizzie
approved these changes
Dec 4, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Dec 4, 2020
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this pull request
Jan 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: