Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: show 'owner' tag for real owner #13689

Merged
merged 8 commits into from
Nov 28, 2020
Merged

ui: show 'owner' tag for real owner #13689

merged 8 commits into from
Nov 28, 2020

Conversation

a1012112796
Copy link
Member

As title
fix #13460

@a1012112796
ui: show 'owner' tag for real owner
2d43ef2 
Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 24, 2020
@codecov-io
Copy link

codecov-io commented Nov 24, 2020 •
edited
Loading

Codecov Report

Merging #13689 (bb62a0d) into master (48c9865) will increase coverage by 0.06%.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13689      +/-   ##
==========================================
+ Coverage   42.19%   42.26%   +0.06%     
==========================================
  Files         697      697              
  Lines       76825    76845      +20     
==========================================
+ Hits        32419    32476      +57     
+ Misses      39057    39025      -32     
+ Partials     5349     5344       -5
Impacted Files Coverage Δ
routers/repo/issue.go 38.09% <54.54%> (+0.09%) ⬆️
models/repo_permission.go 77.06% <63.63%> (-0.72%) ⬇️
models/issue_comment.go 53.32% <0.00%> (+0.45%) ⬆️
services/pull/pull.go 41.17% <0.00%> (+0.49%) ⬆️
models/error.go 37.25% <0.00%> (+0.49%) ⬆️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
routers/repo/view.go 38.11% <0.00%> (+0.64%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
services/pull/patch.go 55.68% <0.00%> (+1.70%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c9865...bb62a0d. Read the comment docs.

@6543 6543 added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.13 labels Nov 24, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 24, 2020
@silverwind
Copy link
Member

Would suggest shortening it just to Administrator.

@a1012112796

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2020
@techknowlogick
Copy link
Member

🚀

@lafriks lafriks merged commit 1e5247d into go-gitea:master Nov 28, 2020
@lafriks
Copy link
Member

lafriks commented Nov 28, 2020

Please send backports

@a1012112796 a1012112796 deleted the fix_comment_tag branch November 29, 2020 08:49
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Nov 29, 2020
@a1012112796 @techknowlogick @lafriks
ui: show 'owner' tag for real owner (go-gitea#13689)
da4fae4 
* ui: show 'owner' tag for real owner

Signed-off-by: a1012112796 <1012112796@qq.com>

* Update custom/conf/app.example.ini

* simplify logic

fix logic
fix a small bug about original author

* remove system manager tag

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lauris BH <lauris@nix.lv>
@a1012112796 a1012112796 mentioned this pull request Nov 29, 2020
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Nov 29, 2020
lafriks added a commit that referenced this pull request Nov 29, 2020
@a1012112796 @techknowlogick @lafriks
ui: show 'owner' tag for real owner (#13689) (#13743)
25421f0 
* ui: show 'owner' tag for real owner

Signed-off-by: a1012112796 <1012112796@qq.com>

* Update custom/conf/app.example.ini

* simplify logic

fix logic
fix a small bug about original author

* remove system manager tag

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind left review comments

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Administratos are refered to as owners in comment headings
8 participants
@a1012112796 @codecov-io @silverwind @techknowlogick @lafriks @zeripath @6543 @GiteaBot