Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 18, 2020

This maybe a break change

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 18, 2020
@codecov-io
Copy link

Codecov Report

Merging #13621 (9cbb2f4) into master (5a991ec) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13621      +/-   ##
==========================================
- Coverage   42.21%   42.20%   -0.02%     
==========================================
  Files         697      697              
  Lines       76563    76561       -2     
==========================================
- Hits        32320    32310      -10     
- Misses      38945    38952       +7     
- Partials     5298     5299       +1     
Impacted Files Coverage Δ
routers/routes/chi.go 34.33% <0.00%> (-1.52%) ⬇️
routers/routes/macaron.go 93.64% <ø> (+1.10%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a991ec...9cbb2f4. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 18, 2020
@silverwind
Copy link
Member

silverwind commented Nov 18, 2020

Can we maybe consolidate our CORS setting here too? We have the cors category and then there's the sole repository.ACCESS_CONTROL_ALLOW_ORIGIN which I think should be removed for clarity.

Thought it's possible those do two different things.

@lunny
Copy link
Member Author

lunny commented Dec 19, 2020

blocked by #13857

@lunny
Copy link
Member Author

lunny commented Jan 12, 2021

replaced by #14293

@lunny lunny closed this Jan 12, 2021
@lunny lunny deleted the lunny/chi_cors branch January 12, 2021 11:23
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants