Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Only Return Json (#13511) #13565

Merged
merged 1 commit into from
Nov 15, 2020
Merged

[API] Only Return Json (#13511) #13565

merged 1 commit into from
Nov 15, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 14, 2020 •
edited
Loading

Backport #13511

@6543 @zeripath
[API] Only Return Json (go-gitea#13511)
553a62c 
* Let Branch and Raw Endpoint return json error if not found

* Revert "RM RepoRefByTypeForAPI and move needed parts into GetRawFile directly"

This reverts commit d826d08577b23765cb3c257e7a861191d1aa9a04.

* more similar to RepoRefByType

* dedub-code

* API should just speak JSON

* nice name

Co-authored-by: zeripath <art27@cantab.net>
@6543 6543 mentioned this pull request Nov 14, 2020
Merged
@6543 6543 added this to the 1.13.0 milestone Nov 14, 2020
@6543 6543 added modifies/api This PR adds API routes or modifies them type/bug labels Nov 14, 2020
@6543 6543 added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 15, 2020
@6543
Copy link
Member Author

6543 commented Nov 15, 2020

🚀

@zeripath zeripath merged commit 48fca01 into go-gitea:release/v1.13 Nov 15, 2020
@6543 6543 deleted the backport_api-only-json_13511_v113 branch November 15, 2020 20:51
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @silverwind @lafriks @zeripath @GiteaBot