Skip to content

WIP: Move install routes to chi #13558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

WIP: Move install routes to chi #13558

wants to merge 23 commits into from

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 14, 2020 •
edited
Loading

replaced by #14293

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 14, 2020
@lunny lunny force-pushed the lunny/move_install_chi branch 3 times, most recently from 0233e99 to 54edc60 Compare November 17, 2020 07:22
@codecov-io
Copy link

codecov-io commented Nov 17, 2020 •
edited
Loading

Codecov Report

Merging #13558 (dadff13) into master (15a475b) will decrease coverage by 0.07%.
The diff coverage is 1.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13558      +/-   ##
==========================================
- Coverage   41.87%   41.79%   -0.08%     
==========================================
  Files         742      745       +3     
  Lines       79309    79460     +151     
==========================================
+ Hits        33209    33212       +3     
- Misses      40641    40784     +143     
- Partials     5459     5464       +5
Impacted Files Coverage Δ
cmd/web.go 0.00% <0.00%> (ø)
modules/auth/user_form.go 41.07% <ø> (+1.41%) ⬆️
modules/context/default.go 0.00% <0.00%> (ø)
modules/forms/forms.go 0.00% <0.00%> (ø)
modules/forms/install.go 0.00% <0.00%> (ø)
modules/middlewares/cookie.go 0.00% <ø> (ø)
routers/routes/install.go 0.00% <0.00%> (ø)
routers/routes/macaron.go 93.89% <ø> (+0.72%) ⬆️
services/mailer/mail.go 61.29% <0.00%> (ø)
routers/routes/chi.go 37.57% <13.33%> (-0.23%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a475b...dadff13. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 17, 2020
@lunny lunny force-pushed the lunny/move_install_chi branch from 08bf3bf to ff4c4a0 Compare November 24, 2020 00:03
@6543 6543 added this to the 1.14.0 milestone Nov 24, 2020
@lunny lunny force-pushed the lunny/move_install_chi branch from e4b6a87 to 6d5fd8b Compare November 29, 2020 03:45
@lunny
Copy link
Member Author

lunny commented Dec 19, 2020

Blocked by #13857

@lunny lunny force-pushed the lunny/move_install_chi branch 3 times, most recently from 85d8f25 to b583b87 Compare December 20, 2020 03:16
@lunny lunny force-pushed the lunny/move_install_chi branch from 9dcd9f3 to dadff13 Compare January 5, 2021 13:52
6543
6543 reviewed Jan 5, 2021
View reviewed changes
6543
6543 reviewed Jan 5, 2021
View reviewed changes
modules/options/static.go Outdated
Copy link
Member

@6543 6543 Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func AssetNames() []string {} has no desciption -> lint issue

@lunny lunny force-pushed the lunny/move_install_chi branch from 4e8c771 to 2495059 Compare January 8, 2021 12:25
@lunny lunny removed this from the 1.14.0 milestone Jan 13, 2021
@lunny lunny closed this Jan 13, 2021
@lunny lunny deleted the lunny/move_install_chi branch January 13, 2021 03:22
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@6543 6543 6543 left review comments

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @codecov-io @6543 @GiteaBot