Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use existing analyzer module for language detection for highlighting (#13522) #13551

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Use existing analyzer module for language detection for highlighting (#13522) #13551

merged 1 commit into from
Nov 13, 2020

Conversation

mrsdizzie
Copy link
Member

Backport of #13522

@mrsdizzie @zeripath
@lafriks @techknowlogick
Use existing analyzer module for language detection for highlighting (g…
5003eca 
…o-gitea#13522)

* Use existing analyzer module for language detction for highlighting

Thanks @lafriks for pointing out we can reuse existing code for more reliable language detection here.

* Update modules/highlight/highlight.go

Co-authored-by: Lauris BH <lauris@nix.lv>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 13, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 13, 2020
@techknowlogick techknowlogick merged commit b4d18da into go-gitea:release/v1.13 Nov 13, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Nov 13, 2020
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Nov 13, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mrsdizzie @silverwind @techknowlogick @GiteaBot