Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify layout between auth pages #13547

Merged
merged 2 commits into from
Nov 14, 2020

Conversation

noerw
Copy link
Member

@noerw noerw commented Nov 13, 2020

Several auth pages had plenty of differences in container width, style for tabs / menu, text alignment. This is now all unified.
Also fixes a broken form layout on /user/link_account page on large screens.

This makes changes to the templates, but should be compatible to the old structure (I made sure to keep the important classes)

page this PR v1.13.0-rc1
sign up grafik grafik
sign in grafik grafik
link account grafik grafik

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 13, 2020
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Nov 13, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Nov 13, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #13547 (d9e2212) into master (6280af0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13547      +/-   ##
==========================================
- Coverage   42.17%   42.16%   -0.02%     
==========================================
  Files         696      696              
  Lines       76438    76438              
==========================================
- Hits        32241    32232       -9     
- Misses      38911    38920       +9     
  Partials     5286     5286              
Impacted Files Coverage Δ
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 48.90% <0.00%> (-2.92%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/charset/charset.go 73.03% <0.00%> (+4.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c76c5c...d9e2212. Read the comment docs.

@techknowlogick techknowlogick merged commit e16b0e5 into go-gitea:master Nov 14, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants