Fix panic bug in handling multiple references in commit #13486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue lay in determining the position of matches on a second run round a commit message in FindAllIssueReferences. Fix go-gitea#13483 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
issue/critical
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Nov 9, 2020
GiteaBot
added
the
lgtm/need 1
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Nov 9, 2020
The issue lay in determining the position of matches on a second run round a commit message in FindAllIssueReferences. Fix go-gitea#13483 Signed-off-by: Andrew Thornton <art27@cantab.net>
Member
|
Backport: #13487 |
Codecov Report
@@ Coverage Diff @@
## master #13486 +/- ##
==========================================
+ Coverage 42.18% 42.20% +0.01%
==========================================
Files 694 694
Lines 76330 76334 +4
==========================================
+ Hits 32201 32213 +12
+ Misses 38859 38846 -13
- Partials 5270 5275 +5
Continue to review full report at Codecov.
|
lafriks
approved these changes
Nov 9, 2020
GiteaBot
added
lgtm/done
Member
|
🚀 |
techknowlogick
pushed a commit
that referenced
this pull request
Nov 10, 2020
) * Fix panic bug in handling multiple references in commit (#13486) The issue lay in determining the position of matches on a second run round a commit message in FindAllIssueReferences. Fix #13483 Signed-off-by: Andrew Thornton <art27@cantab.net> * CI.restart() Co-authored-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue lay in determining the position of matches on a second run round
a commit message in FindAllIssueReferences.
Fix #13483
Signed-off-by: Andrew Thornton art27@cantab.net